feat: newArrival attribute #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htuzel
reviewed
Dec 5, 2024
| newArrivalsCategory: function(productModel) { | ||
| if (!empty(productModel.categories)) { | ||
| for (var i = 0; i < productModel.categories.length; i += 1) { | ||
| var rootCategoryId = productModel.categories[i][productModel.categories[i].length - 1].id; |
There was a problem hiding this comment.
Maybe we give it a name as lastCategoryId as it refers to the ID of the last category in the chain
There was a problem hiding this comment.
Oh sure, I went with topLevelCategoryId to match SFCC naming: isTopLevel()
htuzel
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, we have a
newArrivalsCategoryattribute which contains hierarchical facets.But displaying two hierarchical facets on the UI can create confusion and duplicates the information:
SFRA default UI uses a "New Arrival" checkbox.
This PR adds a
newArrivalboolean attribute, set to true when a product belongs to thenewarrivalscategory, and atoggleRefinementwidget that permits to show a simple refinement checkbox similar to SFRA:Changes
productModelCustomizerto also handle thenewArrivalattributetoggleRefinementwidget on the UI, and the CSS to have the same look and feel than SFRAlabelTextand no custom CSSHow to test
newArrivalto the Additional Product Attributes and run the product index jobSFCC-406
SFCC-407